Skip to content

Add support for deleting by ip-address and subnet to support empty name.#11196

Merged
qwordy merged 4 commits into
Azure:devfrom
madsd:rule-name-fix
Dec 10, 2019
Merged

Add support for deleting by ip-address and subnet to support empty name.#11196
qwordy merged 4 commits into
Azure:devfrom
madsd:rule-name-fix

Conversation

@madsd

@madsd madsd commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Fix issue #10965

Add support for deleting by ip-address and subnet to support empty name.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@madsd madsd requested a review from qwordy as a code owner November 12, 2019 15:26
@panchagnula panchagnula added this to the S161 milestone Nov 12, 2019
@fengzhou-msft

Copy link
Copy Markdown
Member

@qwordy please review the changes.

@fengzhou-msft fengzhou-msft reopened this Nov 13, 2019
@panchagnula panchagnula changed the title Fix issue #10965 Add support for deleting by ip-address and subnet to support empty name. Nov 19, 2019
@madsd

madsd commented Nov 26, 2019

Copy link
Copy Markdown
Contributor Author

@qwordy can you review this, or let me know if I need to do something to push this forward?

@panchagnula panchagnula modified the milestones: S161, S162 Nov 27, 2019
@panchagnula

Copy link
Copy Markdown
Contributor

@madsd now that we have a new version released could you move the history item to the next release. Will make sure to take this with the upcoming release.

- Allow empty Name
- Allow multiple entries of same IP or Subnet
@madsd

madsd commented Nov 28, 2019

Copy link
Copy Markdown
Contributor Author

@panchagnula History entry has been moved to the next version

@yonzhan yonzhan requested a review from mmyyrroonn December 1, 2019 03:23
@yonzhan

yonzhan commented Dec 1, 2019

Copy link
Copy Markdown
Collaborator

@qwordy please help with the PR.

@qwordy qwordy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@qwordy qwordy merged commit 3aee4f8 into Azure:dev Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants